[openstreetmap/openstreetmap-website] Update rails-dom-testing to 2.3.0 (PR #6318)

Anton Khorev notifications at github.com
Wed Aug 13 16:04:59 UTC 2025


@AntonKhorev commented on this pull request.



> @@ -421,7 +421,7 @@ def test_create
     post user_blocks_path
     assert_response :not_found
     assert_template "users/no_such_user"
-    assert_select "h1", "The user  does not exist"
+    assert_select "h1", "The user does not exist"

This breaks because the message itself doesn't make sense, if we take i18n into account. There's an empty username with spaces around it. Temporarily I'd do `:html` fix like in [changesets_helper_test](https://github.com/openstreetmap/openstreetmap-website/pull/6318/files#r2273910522) because it allows commits to be in a different order.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6318#pullrequestreview-3116675579
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6318/review/3116675579 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250813/324fe244/attachment.htm>


More information about the rails-dev mailing list