[openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of .js.erb files (PR #5559)
Andy Allan
notifications at github.com
Wed Feb 5 16:40:59 UTC 2025
@gravitystorm commented on this pull request.
> "eslint": "^9.0.0",
+ "eslint-plugin-erb": "^2.1.0",
"@stylistic/eslint-plugin-js": "^3.0.0",
"eslint-formatter-compact": "^8.40.0"
> How should we sort the plugins?
Either a linter picks up on this, or it doesn't really matter. :smile:
For comparison, we use [`Bundler/OrderedGems`](https://docs.rubocop.org/rubocop/1.71/cops_bundler.html#bundlerorderedgems) for our Gemfile.
It's best to have this sort of thing linted, rather than manually maintained, because if we manually maintain it we need to keep remembering about it, discussing it, and asking new developers to learn the hard way about whatever the un-linted convention is.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#discussion_r1943303401
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5559/review/2596375001 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250205/a72279be/attachment.htm>
More information about the rails-dev
mailing list