[openstreetmap/openstreetmap-website] Transition more requests to fetch (PR #5669)

Tom Hughes notifications at github.com
Thu Feb 13 20:34:56 UTC 2025


@tomhughes commented on this pull request.



>  
-      noteLoader = null;
+          for (var id in oldNotes) {
+            noteLayer.removeLayer(oldNotes[id]);
+          }
+        })
+        .catch(() => {})

So this is what I wasn't sure about - what happens if a fetch is rejected and nothing catches the rejection.

If that leads to a message in the console then we should probably have a no-op catch on all of them? Unless we want network errors to get reported in the console but in that case the ones that exist to catch aborts should rethrow other errors?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669#discussion_r1955178113
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5669/review/2616161648 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250213/12699d39/attachment.htm>


More information about the rails-dev mailing list