[openstreetmap/openstreetmap-website] Move edit account action to show (PR #5696)

Tom Hughes notifications at github.com
Mon Feb 17 08:47:28 UTC 2025


@tomhughes commented on this pull request.

I'm not sure there's a good reason for the step by step change of `edit_account_path` to `account_path` here... I'd be inclined to squash all that down into the main commit (which already changes some uses) and just have the two preparatory commits and the one main commit.

>      scope :module => :accounts do
       resource :terms, :only => [:show, :update]
       resource :pd_declaration, :only => [:show, :create]
       resource :deletion, :only => :show
       resource :home, :only => :show
     end
   end
+  get "/account/edit", :to => redirect(:path => "/account"), :as => nil

Do we actually need this redirect? Are we expecting sites outside openstreetmap.org to have direct links to the account edit page?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5696#pullrequestreview-2620378439
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5696/review/2620378439 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250217/06827aee/attachment.htm>


More information about the rails-dev mailing list