[openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

Anton Khorev notifications at github.com
Mon Feb 17 16:19:44 UTC 2025


@AntonKhorev commented on this pull request.



> +  <div class="text-body-secondary d-flex mb-3">
+    <%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg",
+                  :alt => social_link.parsed[:platform].nil? ? "other" : social_link.parsed[:platform],
+                  :class => "me-2" %>
+    <%= link_to social_link.parsed[:name], social_link.url, :class => "text-body-secondary d-block text-truncate", :rel => "nofollow me" %>
+  </div>

What do you think about this?

```suggestion
  <%= link_to social_link.url, :class => "icon-link mw-100 text-body-secondary mb-3", :rel => "nofollow me" do %>
    <%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg",
                  :alt => social_link.parsed[:platform].nil? ? "other" : social_link.parsed[:platform],
                  :size => "16" %>
    <span class="text-truncate">
      <%= social_link.parsed[:name] %>
    </span>
  <% end %>
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#pullrequestreview-2621496626
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5439/review/2621496626 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250217/74be6337/attachment.htm>


More information about the rails-dev mailing list