[openstreetmap/openstreetmap-website] Move jquery .load() to fetch (PR #5731)

Holger Jeromin notifications at github.com
Fri Feb 28 07:46:28 UTC 2025


@HolgerJeromin commented on this pull request.



> +        .then(html => $section.html(html))
+        .then(update);

Right now `update` will get the html from the `.html(html)` [jquery call](https://api.jquery.com/html/#html2).
This would prevent "leaking" the data into the next promise chain:
```suggestion
        .then(html => {
             $section.html(html)
             return;
           })
        .then(update);
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5731#pullrequestreview-2649992818
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5731/review/2649992818 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250227/ae7b40a7/attachment-0001.htm>


More information about the rails-dev mailing list