[openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

Anton Khorev notifications at github.com
Thu Jan 2 10:38:34 UTC 2025


@AntonKhorev commented on this pull request.



> +  belongs_to :befriender, :class_name => "User", :foreign_key => :user_id, :inverse_of => :follows
+  belongs_to :befriendee, :class_name => "User", :foreign_key => :friend_user_id, :inverse_of => :follows

We probably want to keep the existing db column names like `friend_user` for now, but what about `:befriender` and `:befriendee`? Currently you have code like this, mixing "follow" and "friend" terminology:

```ruby
Follow.find_by(:befriender => user, :befriendee => follow)
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2527347738
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5261/review/2527347738 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250102/1d07ead2/attachment.htm>


More information about the rails-dev mailing list