[openstreetmap/openstreetmap-website] Label administrative boundaries by real-world designation (PR #5493)

[Tom Hughes]

@tomhughes commented on this pull request.

I'm not totally convinced showing the numeric level is useful but generally this looks good apart from the specific point I've mentioned in a comment.

> @@ -101,9 +101,13 @@ def search_osm_nominatim
       if klass == "boundary" && type == "administrative"
         rank = (place.attributes["address_rank"].to_i + 1) / 2
         prefix_name = t "geocoder.search_osm_nominatim.admin_levels.level#{rank}", :default => prefix_name
+        border_type = false
+        place_type = false

I think `nil` would be a better initial value here given they are going to be strings if any match is found.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5493#pullrequestreview-2545469269
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5493/review/2545469269 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250112/235a06db/attachment.htm>