[openstreetmap/openstreetmap-website] Label administrative boundaries by real-world designation (PR #5493)

Minh Nguyễn notifications at github.com
Mon Jan 13 00:19:56 UTC 2025


@1ec5 commented on this pull request.



> +          border_type = t "geocoder.search_osm_nominatim.border_types.#{extratag.attributes['value']}", :default => prefix_name if extratag.attributes["key"] == "border_type"
+          place_type = t "geocoder.search_osm_nominatim.prefix.place.#{extratag.attributes['value']}", :default => prefix_name if extratag.attributes["key"] == "linked_place" || extratag.attributes["key"] == "place"

Yes, good catch. I originally had two loops that set `prefix_name` directly. Now we probably don’t need a `:default` at all.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5493#discussion_r1912575079
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5493/review/2545564576 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250112/8fb8e648/attachment.htm>


More information about the rails-dev mailing list