[openstreetmap/openstreetmap-website] Label administrative boundaries by real-world designation (PR #5493)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> +          border_type = t "geocoder.search_osm_nominatim.border_types.#{extratag.attributes['value']}", :default => prefix_name if extratag.attributes["key"] == "border_type"
+          place_type = t "geocoder.search_osm_nominatim.prefix.place.#{extratag.attributes['value']}", :default => prefix_name if extratag.attributes["key"] == "linked_place" || extratag.attributes["key"] == "place"

Shouldn't `:default` be `border_type` and `place_type` correspondingly, given that later the values are combined with `place_type || border_type || prefix_name`?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5493#pullrequestreview-2545563214
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5493/review/2545563214 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250112/d2db2b0a/attachment-0001.htm>