[openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

[Andy Allan]

If I had to guess, my guess would be that your locale on the website is "en-GB". This would allow for the email in the screenshot, because:

* In en.yml the `friendship_notification.subject` text was changed, but the i18n key remained the same
* In en.yml the email content was changed, and the i18n key was also changed from `had_added_you` to `followed_you`
* Then the deployment happened, but en-GB.yml was not yet updated at this point
* So en-GB.yml had the old `subject` text and still said "friend"
* and en-GB.yml did not have the new `followed_you` key
* Then the email was created, with en-GB as the locale. The subject in en-GB was therefore the old subject. The `followed_you` key was not yet available, and so that was looked up in `en.yml` to find the text, which is the new one.

This is just guesswork though, maybe something else happened, but it at least fits what you observed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#issuecomment-2612925341
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5261/c2612925341 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250124/db920806/attachment.htm>