[openstreetmap/openstreetmap-website] Refactor embed.js.erb with layers.yml (PR #5571)

Tom Hughes notifications at github.com
Fri Jan 31 17:34:53 UTC 2025


@tomhughes requested changes on this pull request.

The code changes here look great now but the commit history is rather messy - can we get rid of the merges please and rebase it instead? and merge any fixup commits into the thing they're fixing - having two `Refactor embed.js.erb with layers.yml` commits in one PR can't be right.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#pullrequestreview-2587369257
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5571/review/2587369257 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250131/6308284d/attachment-0001.htm>


More information about the rails-dev mailing list