[openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> @@ -55,10 +55,10 @@ describe("OSM", function () {
     it("parses bbox params", function () {
       const expected = L.latLngBounds([57.6247, -3.6845], [57.7247, -3.7845]);
       let params = OSM.mapParams("?bbox=-3.6845,57.6247,-3.7845,57.7247");
-      expect(params).to.have.property("bounds").deep.equal(expected);
+      expect(L.latLngBounds(params.bounds)).to.deep.equal(expected);

The test claims to test `.mapParams`. Why does it need to convert both the expected and the actual value to `L.latLngBounds` before comparing them?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6076#pullrequestreview-2928959849
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6076/review/2928959849 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250614/5c3b9fe8/attachment.htm>