[openstreetmap/openstreetmap-website] Move share sidebar to view (PR #6106)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
+  before_action :authorize_web
+  before_action :set_locale
+  authorize_resource :class => false
+
+  def show
+    expires_in 7.days, :public => true

Are you sure you're not forgetting about `config/locales/*.yml`? Because what's going to happen is: you move i18n strings, this invalidates all localized stings for some time, somebody opens the pane and gets it not localized, next day maybe translatewiki pushes the update with strings moved to their new place, but that person won't see this for another week because the pane is cached.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6106#discussion_r2150307743
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6106/review/2932620727 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250616/3d15ff6c/attachment.htm>