[openstreetmap/openstreetmap-website] Move share sidebar to view (PR #6106)
Anton Khorev
notifications at github.com
Mon Jun 16 16:03:01 UTC 2025
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
+ before_action :authorize_web
+ before_action :set_locale
+ authorize_resource :class => false
+
+ def show
+ expires_in 7.days, :public => true
I was going to say that if you want the browser to recheck whether the page has changed and receive `304
Not Modified` if it hasn't, this is what normally happens without extra caching instructions. But now I'm not entirely sure after looking at new note pages in the left sidebar, could be that `?xhr=1` unfinished buisiness.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6106#discussion_r2150364526
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6106/review/2932712554 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250616/655ce247/attachment-0001.htm>
More information about the rails-dev
mailing list