[openstreetmap/openstreetmap-website] Preserve `referer` during oauth JS confirmation (PR #6138)

Tom Hughes notifications at github.com
Fri Jun 27 16:34:07 UTC 2025


@tomhughes commented on this pull request.



> @@ -14,6 +14,7 @@ class ConfirmationsController < ApplicationController
   before_action :require_cookies, :only => [:confirm]
 
   def confirm
+    # The post happens in confirm.html.erb and user.js

I don't think this is very useful - even if you accept it's true right now, and that depends on how you define "happens" exactly, there's no guarantee that those locations will stay the same and nobody will find and update this if they change one of those files.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6138#pullrequestreview-2967198355
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6138/review/2967198355 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250627/1c2cbf83/attachment.htm>


More information about the rails-dev mailing list