[openstreetmap/openstreetmap-website] Removes optional using first comments records (PR #5744)

[Tom Hughes]

@tomhughes commented on this pull request.



>      comment = create(:note_comment, :author => user)
-    assert_equal user, comment.note.author
+    assert_equal "Default note's description", comment.note.description

Why move this from `test_author` to `test_description` exactly?

I mean obviously it is now testing the description, but why? It just seems to be duplicating the testing that's already done (unless you expect setting the author to change the behaviour of description) while not actually testing `author` at all anymore?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5744#pullrequestreview-2658597673
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5744/review/2658597673 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250304/8afdae2a/attachment.htm>