[openstreetmap/openstreetmap-website] I18n fallback fixes (PR #5745)

Tom Hughes notifications at github.com
Sat Mar 8 15:09:49 UTC 2025


@tomhughes commented on this pull request.



> @@ -21,7 +21,6 @@
 
   I18n.default_locale = OSM.DEFAULT_LOCALE;
   I18n.locale = locale;
-  I18n.fallbacks = true;

As I explained when I opened this PR the embed case is different - there we load `embed.js` which contains only a single string but does contain all languages - we do it that way because language selection has to happen client side.

That said I just realised that although it contains all languages it has already applied fallback to them, so there is no opportunity to do client fallback.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5745#discussion_r1986099152
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5745/review/2669207106 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250308/10818411/attachment-0001.htm>


More information about the rails-dev mailing list