[openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)

Marwin Hochfelsner notifications at github.com
Wed Mar 12 15:57:02 UTC 2025


@hlfan commented on this pull request.



> +      mapParams.mlon = parseFloat(geoURI.lon);
+      mapParams.mlat = parseFloat(geoURI.lat);

I'd say show a marker so later when uncertainty support is implemented in an approved way,
changing L.marker to L.circle when a radius is specified in https://github.com/openstreetmap/openstreetmap-website/blob/a28f78c69a19c9c41dc96dcaad9f87cf5b530f96/app/assets/javascripts/index.js#L225 doesn't alter the UX too much. Otherwise it would be more confusing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1991813305
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5736/review/2679043800 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250312/b2d489c7/attachment.htm>


More information about the rails-dev mailing list