[openstreetmap/openstreetmap-website] Put api keys directly in js layer definitions (PR #5809)

Tom Hughes notifications at github.com
Sun Mar 16 15:44:19 UTC 2025


@tomhughes commented on this pull request.



> @@ -0,0 +1,19 @@
+module MapLayers
+  def self.full_definitions(layers_filename)
+    YAML.load_file(Rails.root.join(layers_filename)).filter_map do |layer|

This isn't actually doing any filtering it is? The block always returns a "truthy" value so a simple `map` would work equally well?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5809#pullrequestreview-2688730270
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5809/review/2688730270 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250316/43034868/attachment.htm>


More information about the rails-dev mailing list