[openstreetmap/openstreetmap-website] Change heatmap color to sqrt from 0 to max changes (PR #5833)
Anton Khorev
notifications at github.com
Fri Mar 21 14:03:56 UTC 2025
@AntonKhorev commented on this pull request.
> @@ -59,9 +60,10 @@ document.addEventListener("DOMContentLoaded", () => {
},
scale: {
color: {
- type: "threshold",
+ type: "sqrt",
+ // reverse mutates the array. But with theme changes we must work on the original data.
What does this comment say?
If we need to stop contributors from trying `rangeColors.reverse()` [again](https://github.com/openstreetmap/openstreetmap-website/pull/5402#discussion_r1923048595) and again, we can have two different `rangeColors` arrays defined earlier. Maybe the colors in them also need to be different, not just reversed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5833#pullrequestreview-2706077318
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5833/review/2706077318 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250321/a681e945/attachment.htm>
More information about the rails-dev
mailing list