[openstreetmap/openstreetmap-website] Clean OSM.formatHash calls (PR #5887)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -23,6 +23,12 @@ def result_to_html(result)
     safe_join(html)
   end
 
+  def map_hash(params)
+    return "" unless params[:lat].present? && params[:lon].present?
+
+    "#map=#{params[:zoom].to_i || 17}/#{params[:lat].to_f}/#{params[:lon].to_f}"

Why do we need to convert lat and lon to floating point and then immediately back to string again?

> @@ -81,7 +81,8 @@
 <% if params[:oauth_return_url] %>
   <a class="btn btn-primary" href="<%= params[:oauth_return_url] %>"><%= t ".continue_authorization" %></a>
 <% else %>
-  <a class="btn btn-primary start-mapping" href="<%= edit_path %>"><%= t ".start_mapping" %></a>
+  <%= editor_query = "?editor=#{params[:editor].to_s.split(/\W/)[0]}" if params[:editor].present?

Why do we need to split the editor into words and then just take the first one? The javascript implementation that this is replacing doesn't seem to do that?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887#pullrequestreview-2819123248
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5887/review/2819123248 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250506/24dcca27/attachment.htm>