[openstreetmap/openstreetmap-website] Refactor Heatmap: Manual Labels & Yearly Template (PR #5906)

[Emin Kocan]

kcne left a comment (openstreetmap/openstreetmap-website#5906)

Thanks everyone for the valuable feedback.

I completely understand the concerns around code complexity. My initial intent was to address the visual inconsistency of showing "empty" days beyond today’s date and to ensure proper localization of week starts — something users from different locales will appreciate. I agree that this resulted in more manual code than ideal, especially after trying to avoid CSP issues introduced by the plugin.

Regarding the domain naming: it's a bit misleading, I agree. I’m could rename it to something more accurate, like daysYearlyDomain, to better reflect its structure and avoid confusion.

I also noticed the alternative PR (#5998), which, to be honest, is a much simpler approach that achieves the same goal. I’m open to closing this in favor of merging the better solution, even though I’ve spent quite a bit of time working through this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5906#issuecomment-2875086838
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5906/c2875086838 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250512/e3ad6760/attachment.htm>