[openstreetmap/openstreetmap-website] Extract heatmap data assembly into helper (PR #6018)
Tom Hughes
notifications at github.com
Sat May 17 13:40:43 UTC 2025
@tomhughes commented on this pull request.
> @@ -2,6 +2,7 @@ class UsersController < ApplicationController
include EmailMethods
include SessionMethods
include UserMethods
+ include HeatmapHelper
This should probably be a `HeatmapMethods` concern rather than a helper - helpers are primarily about adding methods to view, where they are made available automatically, while concerns are about extending models and controllers.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6018#pullrequestreview-2848284315
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6018/review/2848284315 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250517/9c6f52b4/attachment-0001.htm>
More information about the rails-dev
mailing list