[openstreetmap/openstreetmap-website] Migrate the dashboard entry page from leaflet to maplibre (PR #6504)

[Pablo Brasero]

@pablobm commented on this pull request.

Tested in my machine and looks great. Even gave the globe view a whirl 🙂 I'll leave to others to review though as I'm sure there's tricky, non-obvious stuff.

> @@ -0,0 +1,6 @@
+
+/*
+ *= require maplibre-gl
+ */
+
+/* BASED ON leaflet-all.scss */

This comment probably can go. (I see it's like this in OHM.)

> @@ -62,7 +62,7 @@ class DashboardSystemTest < ApplicationSystemTestCase
       assert_no_text "Your location"
       assert_no_link "Fred Tester"
 
-      find(".leaflet-marker-icon").click
+      find(".maplibregl-marker", :wait => 60).click

Was this giving you trouble? 60 seconds sounds a bit excessive to me.

On app/assets/stylesheets/maplibre-gl-all.scss:

Good question. Personally I would expect the MapLibre styles to live here, but I don't know if there are any historical reasons why it's done differently. It was done like this in the original PR (https://github.com/openstreetmap/openstreetmap-website/pull/121) and I can't see an explanation as to why.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6504#pullrequestreview-3428391359
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6504/review/3428391359 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251106/bec8495b/attachment.htm>