[openstreetmap/openstreetmap-website] Adjust Bootstrap icon usage (PR #6501)
Pablo Brasero
notifications at github.com
Thu Nov 6 14:58:07 UTC 2025
@pablobm commented on this pull request.
> + <i class="bi bi-star-fill fs-5 role-<%= role %> align-middle" title="<%= t ".revoke.#{role}" %>" aria-hidden="true"></i>
+ <span class="visually-hidden"><%= t ".revoke.#{role}" %></span>
Following my experiment above, I think in these cases we should leave the span in place and remove the icon title.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6501#discussion_r2499270559
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6501/review/3428594796 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251106/fbc53e29/attachment.htm>
More information about the rails-dev
mailing list