[openstreetmap/openstreetmap-website] Adjust Bootstrap icon usage (PR #6501)

[Marwin Hochfelsner]

@hlfan commented on this pull request.



>                <span class="visually-hidden"><%= t ".title_label" %></span>
               <%= link_to entry.title, diary_entry_path(@user, entry), :class => "align-self-center lh-sm" %>
             </p>
             <p class="card-text flex-grow-1"><%= truncate(strip_tags(entry.body.to_html), :length => 150) %></p>
 
             <div class="card-text d-flex justify-content-between align-items-center mt-auto">
               <small class="text-body-secondary d-flex gap-1 align-items-center">
-                <i class="bi bi-chat fs-5 my-n1" aria-hidden="true"></i>
+                <i class="bi bi-chat fs-5 my-n1" title="<%= t ".comments_label" %>" aria-hidden="true"></i>

What do you think of removing the span elements and adding role=img, aria-label=* AND title=* instead of the aria-hidden?
Then there's just one element, even though there's still two translated texts specified.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6501#discussion_r2502335674
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6501/review/3432532583 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251107/1692674b/attachment.htm>