[openstreetmap/openstreetmap-website] Rename export controller actions (PR #6551)

Andy Allan notifications at github.com
Thu Nov 20 17:49:27 UTC 2025


Refs #5539

Although I've renamed the actions, I've left the urls alone for now. Further refactoring might include things like:

* Reconsider whether the embedded html source, data download and image export functionality should all really be in the same controller
* Make resourceful routes for whatever gets decided
* Remove hardcoded form target urls from forms and use route helpers instead
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6551

-- Commit Summary --

  * Rename export controller actions

-- File Changes --

    M .rubocop.yml (1)
    M app/abilities/ability.rb (2)
    M app/controllers/export_controller.rb (12)
    R app/views/export/show.html.erb (0)
    M app/views/site/export.html.erb (2)
    M config/routes.rb (4)
    M test/controllers/export_controller_test.rb (26)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6551.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6551.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6551
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6551 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251120/be422091/attachment.htm>


More information about the rails-dev mailing list