[openstreetmap/openstreetmap-website] WIP: devcontainer configuration (PR #6424)
Pablo Brasero
notifications at github.com
Fri Oct 3 11:15:11 UTC 2025
pablobm left a comment (openstreetmap/openstreetmap-website#6424)
Another funny one. Relevant commit: https://github.com/openstreetmap/openstreetmap-website/pull/6424/commits/cf421c07312452af6e28f6924dc019ad4c3c33db. The test [test/system/select_language_test.rb](https://github.com/openstreetmap/openstreetmap-website/blob/4191555f2846ac6e6f353b29c7d48f9ef9261efb/test/system/select_language_test.rb) fails with remote Selenium because there is no HTTPS, and therefore it can't set "secure" cookies.
I'm ignorant on this topic: should we bother with secure cookies? We force HTTPS anyway 🤔 Alternatively, we could have a setting in the JS that announces whether we are in production mode, and then set `secure: true` or not depending on that.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3365300937
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6424/c3365300937 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251003/9b74d64b/attachment.htm>
More information about the rails-dev
mailing list