[openstreetmap/openstreetmap-website] WIP: devcontainer configuration (PR #6424)

Marwin Hochfelsner notifications at github.com
Sat Oct 4 08:24:09 UTC 2025


@hlfan commented on this pull request.

I think the cookies clean up doesn't need that much of investigation ahead of pulling it into its own PR.

> @@ -0,0 +1,17 @@
+name: devcontainer
+
+on:
+  - push
+  - pull_request
+

Could the superseded workflow cancellation work here too?

> @@ -27,6 +27,8 @@ OSM = {
       end.to_json
   %>,
 
+  COOKIES: Cookies.withAttributes({ path: "/", samesite: "lax", secure: <%= (Settings.server_protocol == "https").to_json %> }),

Since this isn't a constant, I'd like it to be in lowercase.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6424#pullrequestreview-3301671767
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6424/review/3301671767 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251004/f795daa4/attachment.htm>


More information about the rails-dev mailing list