[openstreetmap/openstreetmap-website] Include preferred_username claim in OIDC ID token (PR #6429)

Pablo Brasero notifications at github.com
Mon Oct 6 11:15:30 UTC 2025


@pablobm commented on this pull request.



> @@ -110,7 +110,7 @@ def test_openid_connect
     end
 
     assert_equal user.id.to_s, data["sub"]
-    assert_not data.key?("preferred_username")

This assertion gives me pause, explicitly checking that the key is not present. Waiting to see what others say. If this PR is rejected, at least we should add an explanatory comment in this test.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6429#pullrequestreview-3303945202
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6429/review/3303945202 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251006/0ff4cc52/attachment.htm>


More information about the rails-dev mailing list