[openstreetmap/openstreetmap-website] Include preferred_username claim in OIDC ID token (PR #6429)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -110,7 +110,7 @@ def test_openid_connect
     end
 
     assert_equal user.id.to_s, data["sub"]
-    assert_not data.key?("preferred_username")

Well I think it was always meant to be there - what else is that line there for?

The discussion in #4226 all seems to suggest it was intended to be there and the commit message for 64bcf7652bc1053741ab58f3ff54505b3d7820ad says it's returned as a claim for the openid scope...

Quite why that assertion wound up asserting the opposite I'm not sure!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6429#discussion_r2407766333
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6429/review/3306385709 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251006/a928f164/attachment.htm>