[openstreetmap/openstreetmap-website] DB seed script (PR #6432)

[Pablo Brasero]

@pablobm commented on this pull request.



> @@ -17,6 +17,9 @@ FileUtils.chdir APP_ROOT do
   puts "== Installing dependencies =="
   system("bundle check") || system!("bundle install")
 
+  # Install JavaScript dependencies
+  system("yarn install --check-files")
+

How about going the other way around?

- From the discussion at https://github.com/openstreetmap/openstreetmap-website/issues/2344, I think we agree that we can drop Vagrant, so let's do that: https://github.com/openstreetmap/openstreetmap-website/pull/6438.
- Then there's the devcontainer support coming up (https://github.com/openstreetmap/openstreetmap-website/pull/6424) which will lead to dropping the "manual" Docker option and related files.
- The install notes are slightly different: it makes sense to simplify them and therefore we can remove the `--check-files` option.
- Then there's the `bin/update` script comes from the update to Rails 5.2.0. Nowadays you do `rails app:update`, I think that can be removed too (different PR).

All this is in the spirit of trying to stay as similar to stock Rails as possible, which will help in future updates.

Thoughts?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2416321423
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6432/review/3318282897 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251009/f737c17f/attachment.htm>