[openstreetmap/openstreetmap-website] Confirmation popup for Overpass API export (PR #6411)

[Andy Allan]

@gravitystorm requested changes on this pull request.

I agree it's worth having a warning for this link. It would be even better if the link was to the third-party website, for example pre-populating a form or something similar. That website could then take care of things like formats, warnings, etc.

> @@ -37,6 +37,55 @@ OSM.Export = function (map) {
     validateControls();
   }
 
+  async function showConfirmationModal(message) {
+    return new Promise((resolve) => {
+      const modalHtml = `

This block of html should be in a erb view template. It might make sense to put it in the same view template as the overpass api link, since they are closely related.

> @@ -3531,6 +3531,11 @@ en:
       filename: "map"
     embed:
       report_problem: "Report a problem"
+    export:
+      header: Confirm

This should describe the subject of the body, for example "Download XML Data" or something similar

> @@ -3531,6 +3531,11 @@ en:
       filename: "map"
     embed:
       report_problem: "Report a problem"
+    export:
+      header: Confirm
+      body: Do you want to download map data for this area in XML format? Note that large areas may take some time to download.
+      cancel: Cancel
+      ok: OK

Please avoid using "OK" as button text. Instead we should use a verb for the action being taken, e.g. "Download" - see e.g. https://ux.stackexchange.com/a/9960

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6411#pullrequestreview-3262131595
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6411/review/3262131595 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250924/0b3b1d85/attachment.htm>