[openstreetmap/openstreetmap-website] Confirmation popup for Overpass API export (PR #6411)

[Pablo Brasero]

@pablobm commented on this pull request.



> @@ -37,6 +37,28 @@ OSM.Export = function (map) {
     validateControls();
   }
 
+  async function showConfirmationModal() {
+    const $modal = $("#export_confirmation");
+    const $okButton = $("#ok_button");

What I mean is that, technically, an id should be unique to the whole page. So if there's another `id="download_button"` in the future, that will be against the HTML standard and perhaps malfunction with some DOM implementation. With a class, we can have as many `.download_button` as we wish in the same page.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6411#discussion_r2383242535
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6411/review/3273535073 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250926/b8d48d7a/attachment.htm>