[openstreetmap/openstreetmap-website] Use Turbo frames for sidebar loading (PR #7245)
Tom Hughes
notifications at github.com
Tue Jul 28 17:48:26 UTC 2026
@tomhughes commented on this pull request.
> @@ -132,6 +132,7 @@ OSM.Router = function (map, rts) {
}
$(window).on("popstate", function (e) {
+ if (!document.body.classList.contains("map-layout")) return false;
In fact the default target on the sidebar turbo frame is `_top` which surely means that links in the frame will by default do a top level load?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7245#discussion_r3667929955
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/7245/review/4800294606 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260728/589df5f2/attachment.htm>
More information about the rails-dev
mailing list