[openstreetmap/openstreetmap-website] Use Turbo frames for sidebar loading (PR #7245)
Tom Hughes
notifications at github.com
Tue Jul 28 17:51:30 UTC 2026
@tomhughes commented on this pull request.
> @@ -20,10 +20,12 @@
<%= render :partial => "layouts/sidebar_close" %>
- <div id="sidebar_loader" class="my-3 text-center loader" hidden><%= render "loader" %></div>
+ <div id="sidebar_loader" class="my-3 text-center loader"><%= render "loader" %></div>
How does this work now? It's no longer hidden by default ,and the code to turn it on and off when loading a new sidebar is gone?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7245#pullrequestreview-4800319585
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/7245/review/4800319585 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260728/0c5d4cba/attachment.htm>
More information about the rails-dev
mailing list