[openstreetmap/openstreetmap-website] Use Turbo frames for sidebar loading (PR #7245)

[Marwin Hochfelsner]

@hlfan commented on this pull request.



> @@ -20,10 +20,12 @@
 
     <%= render :partial => "layouts/sidebar_close" %>
 
-    <div id="sidebar_loader" class="my-3 text-center loader" hidden><%= render "loader" %></div>
+    <div id="sidebar_loader" class="my-3 text-center loader"><%= render "loader" %></div>

CSS that responds to the turbo-frame busy attribute:

https://github.com/openstreetmap/openstreetmap-website/blob/9e29cea64df960e4aca25e1f97b28d9fe35dced7/app/assets/stylesheets/common.scss#L240-L243

Keeping the `[hidden]` would mean the override would also need `!important`, which I don't like in the CSS, and the way I did that earlier required `@extend`: https://github.com/openstreetmap/openstreetmap-website/pull/7245#discussion_r3629908281

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7245#discussion_r3669625785
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7245/review/4802333684 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260728/18c02d99/attachment.htm>