[openstreetmap/openstreetmap-website] Remove secondary wiki prefix list (PR #7136)

[Marwin Hochfelsner]

@hlfan commented on this pull request.



> +    when /^(?>[a-z:_-]+:)?wikipedia$/
+      lang = "en" if key == "wikipedia"
+    when /^(?>[a-z:_-]+:)?wikipedia:([a-z-]{2,12})$/
       lang = Regexp.last_match(1)

> Also I removed the : from the brackets. I think that's why the ?> was there? Not sure.

Nope, for `name:etymology:wikipedia`, which should stay linkified imo. Needs a test, I know.

> The `[a-z-]{2,12}` is meaningful, used in two places, and the second instance has a comment explaining it. It should be in a descriptive constant/method. Similar with `[a-z:_-]+:`.

Maybe something like `language_code_pattern` from 8e37e99fa00429dbe6dfb90f86b4907d64fa11cb, which Tom didn't like?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7136#discussion_r3396876773
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7136/review/4477879446 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260611/3a9f27eb/attachment.htm>