[openstreetmap/openstreetmap-website] Remove secondary wiki prefix list (PR #7136)

Tom Hughes notifications at github.com
Thu Jun 11 15:00:38 UTC 2026


@tomhughes commented on this pull request.



> +    when /^(?>[a-z:_-]+:)?wikipedia$/
+      lang = "en" if key == "wikipedia"
+    when /^(?>[a-z:_-]+:)?wikipedia:([a-z-]{2,12})$/
       lang = Regexp.last_match(1)

My only objection was that something called `language_code_pattern` should at least attempt to match language codes and not arbitrary strings - if you want to match arbitrary strings then fine but call it something different.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7136#discussion_r3396963023
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7136/review/4477986630 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260611/95e1b839/attachment.htm>


More information about the rails-dev mailing list