[openstreetmap/openstreetmap-website] Remove uses of deprecated `#mark_deleted` (PR #6857)

[Pablo Brasero]

Following https://github.com/openstreetmap/openstreetmap-website/pull/6564, this removes some references to `mark_deleted`, which is deprecated and not in use in production.

Note that this method/transition is not entirely removed. There's an annoying instance at [`test/integration/oauth2_test.rb`](https://github.com/openstreetmap/openstreetmap-website/blob/2c3fd80848d9b120b7abfb4a4d31e7491f0702e0/test/integration/oauth2_test.rb#L249) that I can't quite figure out. Ideally I'd like to transform that to "unsuspend, then soft destroy" to better reflect the transitions that are currently available. However Doorkeeper/OAuth is getting in the way. Leaving it for another time for now.

Since I'm at it, I'm adding a couple of test cases for the `suspended` case in `test/controllers/confirmations_controller_test.rb`. Separate commit.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6857

-- Commit Summary --

  * Stop testing `mark_deleted` as it's deprecated
  * Add tests for the case of suspended accounts

-- File Changes --

    M test/controllers/confirmations_controller_test.rb (42)
    M test/models/user_test.rb (14)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6857.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6857.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6857
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6857 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260304/6aa5bf98/attachment.htm>