[openstreetmap/openstreetmap-website] Add Terms of Use notice to welcome banner (PR #6866)

Pablo Brasero notifications at github.com
Tue Mar 10 11:18:00 UTC 2026


@pablobm commented on this pull request.



> @@ -40,6 +40,10 @@
                                        :corpmembers => link_to(t("layouts.partners_corpmembers"), "https://osmfoundation.org/wiki/Corporate_Members"),
                                        :partners => link_to(t("layouts.partners_partners"), "https://hardware.openstreetmap.org/thanks/") %>
         </p>
+        <p class="fs-7 fw-light">
+          <%= t "layouts.welcome_tou_notice_html",
+                :terms_link => link_to(t("layouts.terms_of_use"), "https://osmfoundation.org/wiki/Terms_of_Use") %>

Uh, good question. My impression is that it should be translatable for consistency. Looking at the current translations, I see this is only customised in the `vi` locale. But one is enough, and a user who arrives to that page via different origins (in the same locale) should get the same results, unless there's a good reason to the contrary.

But! That opens the question of whether they should be the same translation key or different ones. If it's the same one, which one? If it's different keys, we open ourselves to breaking consistency again.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6866#discussion_r2911036511
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6866/review/3921623390 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260310/5727d7cf/attachment-0001.htm>


More information about the rails-dev mailing list