[openstreetmap/openstreetmap-website] Remove required attribute from social link fields marked for destruction (PR #6937)

Alex Towell notifications at github.com
Wed Mar 25 18:42:28 UTC 2026


queelius left a comment (openstreetmap/openstreetmap-website#6937)

I've been programming for 25 years (MS in CS), but I use Claude Code heavily now and rarely write code by hand anymore. Rails is not my language. I did review this code and had Claude walk me through it to make sure I understood what was going on.

The fix strips the `required` attribute from URL inputs when a social link row is hidden via `_destroy`. Two places: the click handler for when the user removes a link, and the page-load block for rows already marked for destruction after a validation error re-render. Without it the browser blocks submission on a hidden required field.

I'm not doing drive-by contributions. I picked a handful of projects I want to follow and help where I can. I work part-time for IDOT (Illinois DOT) and have tried to use OpenStreetMap for transportation work there, so I have some interest in this project beyond the PR.

Sorry about the unticked checkbox. That was careless.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6937?email_source=notifications&email_token=AAK2OLMZN6SYNIA7GBPH2K34SQSBJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJSHA4TCMZSHA42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS2XA4S7MNXW23LFNZ2F633QMVXF6Y3MNFRWW#issuecomment-4128913289
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6937/c4128913289 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260325/4dce488e/attachment.htm>


More information about the rails-dev mailing list