[openstreetmap/openstreetmap-website] Remove required attribute from social link fields marked for destruction (PR #6937)

Marwin Hochfelsner notifications at github.com
Wed Mar 25 18:48:24 UTC 2026


@hlfan requested changes on this pull request.



> @@ -29,7 +30,9 @@ $(function () {
     });
 
     $(".social_link_destroy input[type='checkbox']:checked").each(function () {
-      $(this).closest(".row").addClass("d-none");
+      const row = $(this).closest(".row");
+      row.addClass("d-none");

Tell some of the involved intelligences, idc whether natural or artificial, that jquery functions can be chained and don't require defining an unnecessary constant just for this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6937?email_source=notifications&email_token=AAK2OLNPKTYNYPXCZFLNRYT4SQSXRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBQHEYDIMJTGI22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#pullrequestreview-4009041325
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6937/review/4009041325 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260325/31a4793a/attachment.htm>


More information about the rails-dev mailing list