[openstreetmap/openstreetmap-website] Improve parameter validation using rails parameter methods (PR #7090)

[Tom Hughes]

This addresses the new rubcop warnings from #7087 by making use of `.permit` and other rails parameter handling methods.

It was true as @gravitystorm suggested thaty in some come cases rubocop was making incorrect changes but in most cases there was a better way to do it just not always using the `.permit` method.

With this patch applied the new rubocop rule no longer reports any warnings for me.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/7090

-- Commit Summary --

  * Improve parameter validation using rails parameter methods

-- File Changes --

    M app/controllers/api/changeset_comments/visibilities_controller.rb (4)
    M app/controllers/api/changeset_comments_controller.rb (2)
    M app/controllers/api/changeset_subscriptions_controller.rb (4)
    M app/controllers/api/changesets/closes_controller.rb (2)
    M app/controllers/api/changesets/downloads_controller.rb (2)
    M app/controllers/api/changesets/uploads_controller.rb (2)
    M app/controllers/api/changesets_controller.rb (4)
    M app/controllers/api/messages_controller.rb (10)
    M app/controllers/api/nodes_controller.rb (10)
    M app/controllers/api/note_subscriptions_controller.rb (4)
    M app/controllers/api/notes_controller.rb (14)
    M app/controllers/api/old_nodes/redactions_controller.rb (2)
    M app/controllers/api/old_nodes_controller.rb (2)
    M app/controllers/api/old_relations/redactions_controller.rb (2)
    M app/controllers/api/old_relations_controller.rb (2)
    M app/controllers/api/old_ways/redactions_controller.rb (2)
    M app/controllers/api/old_ways_controller.rb (2)
    M app/controllers/api/relations_controller.rb (10)
    M app/controllers/api/tracepoints_controller.rb (2)
    M app/controllers/api/traces/data_controller.rb (2)
    M app/controllers/api/traces_controller.rb (10)
    M app/controllers/api/user_blocks_controller.rb (2)
    M app/controllers/api/user_preferences_controller.rb (6)
    M app/controllers/api/users_controller.rb (4)
    M app/controllers/api/ways_controller.rb (10)
    M app/controllers/changeset_comments/feeds_controller.rb (2)
    M app/controllers/changeset_subscriptions_controller.rb (6)
    M app/controllers/changesets_controller.rb (8)
    M app/controllers/concerns/query_methods.rb (4)
    M app/controllers/diary_comments_controller.rb (6)
    M app/controllers/diary_entries_controller.rb (18)
    M app/controllers/issue_comments_controller.rb (2)
    M app/controllers/issues/reporters_controller.rb (2)
    M app/controllers/issues_controller.rb (4)
    M app/controllers/messages/mutes_controller.rb (2)
    M app/controllers/messages/read_marks_controller.rb (2)
    M app/controllers/messages/replies_controller.rb (2)
    M app/controllers/messages_controller.rb (4)
    M app/controllers/nodes_controller.rb (2)
    M app/controllers/notes_controller.rb (4)
    M app/controllers/oauth2_applications_controller.rb (2)
    M app/controllers/old_nodes_controller.rb (6)
    M app/controllers/old_relation_members_controller.rb (6)
    M app/controllers/old_relations_controller.rb (6)
    M app/controllers/old_ways_controller.rb (6)
    M app/controllers/redactions_controller.rb (2)
    M app/controllers/relation_members_controller.rb (2)
    M app/controllers/relations_controller.rb (2)
    M app/controllers/searches/latlon_queries_controller.rb (4)
    M app/controllers/sessions_controller.rb (2)
    M app/controllers/site_controller.rb (8)
    M app/controllers/traces/data_controller.rb (2)
    M app/controllers/traces/icons_controller.rb (2)
    M app/controllers/traces/pictures_controller.rb (2)
    M app/controllers/traces_controller.rb (8)
    M app/controllers/user_blocks_controller.rb (4)
    M app/controllers/users/statuses_controller.rb (2)
    M app/controllers/ways_controller.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/7090.patchhttps://github.com/openstreetmap/openstreetmap-website/pull/7090.diff
-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7090
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7090 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260514/e5087481/attachment-0001.htm>