[openstreetmap/openstreetmap-website] Improve parameter validation using rails parameter methods (PR #7090)

[Marwin Hochfelsner]

@hlfan approved this pull request.

Looks good to me overall, one change stuck out to me tho.

>      @frame_id = "member_relation_#{@feature.id}"
 
-    return deny_access(nil) if @feature.redacted? && !params[:show_redactions]
+    return deny_access(nil) if @feature.redacted? && params[:show_redactions].blank?

I'm just curious why you stuck with the existing accessor here:
```suggestion
    return deny_access(nil) if @feature.redacted? && params.exclude?(:show_redactions)
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7090#pullrequestreview-4300914884
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7090/review/4300914884 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260515/f96da46a/attachment.htm>