[talk-au] Victorian Vicmap Address Import Proposal

[Andrew Harvey]

On Wed, 19 May 2021, at 9:17 PM, Yuchen Pei wrote: 
> Andrew: Regarding the proposal, looks good so far. I have not 
> finished reading the code yet.

No worries, I'm still very actively working on it, so expect changes.
 
> Regarding unit type, why not just use addr:unit for all types, 
> including "UNIT", "SHOP", "SUITE" etc. instead of discarding the 
> information?

In the current codebase, I do use `addr:unit` for UNIT, SHOP, SUITE. At https://gitlab.com/alantgeo/vicmap2osm/-/blob/master/lib/filterSource.js it lists which building unit types we use, the others I'm just not sure about so have left out like Carspace, Boatshed, ATM, Gate, Room etc.

When I said in the documentation that this information is omitted, I meant the unit type eg. if it is a Unit, Flat, Shop, Suite is omitted, the actual unit value is retained (into addr:unit).

> Thanks for putting together this proposal - really well written 
> (and educational too)!

Thanks!