[Talk-ca] Canvec.osm samples

Thu May 6 19:41:38 BST 2010

Adam,

The problem was with empty tag managment with a previous version of the osm writer we use.  We are not expecting to lose anything!

Daniel

________________________________

From: Adam Dunn [mailto:dunnadam at gmail.com] 
Sent: 6 mai 2010 13:46
To: Bégin, Daniel
Cc: Talk-CA OpenStreetMap
Subject: Re: [Talk-ca] Canvec.osm samples

Awesome, works. Any idea what was causing it? Are we losing some tag (say for example the conversion was nullifying certain tags, and now we are losing out on those tags)?

Adam

On Thu, May 6, 2010 at 10:06 AM, Bégin, Daniel <Daniel.Begin at rncan-nrcan.gc.ca> wrote:

	Bonjour Adam,

	All Canvec.osm samples have been replaced - there is no more empty tags (<tag/>).  For those who wishes to have a look, you will find links to samples in http://wiki.openstreetmap.org/wiki/CanVec

	I don't know how I did manage to open the previous version in JOSM but this version should open properly!
	Cheers,

	Daniel

________________________________

	From: Adam Dunn [mailto:dunnadam at gmail.com] 

	Sent: 5 mai 2010 17:03
	To: Bégin, Daniel
	Cc: Talk-CA OpenStreetMap 

	Subject: Re: [Talk-ca] Canvec.osm samples

	If you generate new samples, I can test with the latest josm if you want. Looking at the 082H04 sample file (I modified all the offending tags that were preventing loading so that they had k="adam" v="crasher" so I could identify them), there doesn't seem to be a pattern to which objects get the null tags. Some are water related, some are roads, some have names, some don't, etc. Don't know where it would be coming from.

	As for the data itself, most seems quite good. Comparing the sample file to Toporama WMS, I noticed that waterfalls are missing from the sample osm file. Are they available in the Canvec data?

	It looks like roads that are dead-ends have turning circles by default, with a note to remove if it doesn't actually exist? Interesting choice of how to set things up.

	Adam

	On Wed, May 5, 2010 at 1:44 PM, Bégin, Daniel <Daniel.Begin at rncan-nrcan.gc.ca> wrote:

		Thanks Adam,

		obviously it seems there being bad tags in the samples.  I'll replace the samples. 

		About the conversion script, it should be OK because I have succesfully created/uploaded many tiles since then using JOSM.
		http://www.openstreetmap.org/?lat=45.371&lon=-72.271&zoom=11&layers=B000FTF

		Daniel

________________________________

		From: talk-ca-bounces at openstreetmap.org [mailto:talk-ca-bounces at openstreetmap.org] On Behalf Of Adam Dunn
		Sent: 5 mai 2010 16:29
		To: Talk-CA OpenStreetMap 

		Subject: Re: [Talk-ca] Canvec.osm samples

		Got a response on the error here [http://josm.openstreetmap.de/ticket/4971]. Turns out there is a malformed tag, that doesn't have key or value in it (a null tag)
		Here's line 16220 (the offending tag):
		<tag/>
		To compare, here's line 16221 (a properly formed tag):
		<tag k="waterway" v="stream"/>

		The josm developer has put in a better error message regarding what the problem is, but josm still will not load the file.

		So does this come down to there being a bad tag in the original Canvec data, or does the conversion script need some modifying?

		Adam

		On Fri, Apr 30, 2010 at 7:02 PM, Sam Vekemans <acrosscanadatrails at gmail.com> wrote:

			Ideas:
			-mention this on the irc #osm-dev chat. As a JOSM develepor might be
			able to help further
			-zipping : try .bz2 compression, instead of regular zip, maybe it does
			something different to the .osm data?
			-at that same time (with that new josm revision, WMS didnt work for some people)
			-josm doesnt automatically update all the plugins, when you get a new
			version of the main exe file,
			-Osmosis is the tool to combine .osm files, i havent yet been
			sucessful at merging them (on the command line)
			-each node would need a new ID, when merging files, maybe there is a
			max # of features?
			-Also, i'll check with user:MikeyCarter as he has gone ahead and
			converted canvec for the Barrie Ontario area, using a customized
			method.

			Cheers,
			Sam

			On 4/30/10, Adam Dunn <dunnadam at gmail.com> wrote:
			> If I understand correctly, older versions of JOSM would open the file
			> correctly, but new versions will have problems? I'm not the only one here?
			>
			> I got the josm svn from this morning (rev 3213), opened it up in Eclipse,
			> did some debugging, and see that for 082H04_Sample.osm, the error occurs on
			> or near line 16217. It may not be Josm that is at fault, since it seems to
			> handle most other osm files quite well.
			>
			> Please see http://josm.openstreetmap.de/ticket/4971 for the bug that I just
			> filed.
			>
			> Adam
			>
			> On Fri, Apr 30, 2010 at 10:04 AM, Daniel Bégin <jfd553 at hotmail.com> wrote:
			>
			>> Hi Adam,
			>>
			>> I looked at Canvec.osm sample files about one month ago and did not get
			>> any
			>> problems with an earlier version of JOSM (before 3196). I've just tried
			>> using JOSM 3196 and I got the same error message. I'm running on Windows.
			>>
			>> No good explanation to give :-(
			>>
			>> Daniel
			>>
			>> -----Original Message-----
			>> From: Adam Dunn [mailto:dunnadam at gmail.com]
			>> Sent: April 29, 2010 12:46
			>> To: Sam Vekemans
			>> Cc: Daniel Bégin; Talk-CA OpenStreetMap
			>> Subject: Re: [Talk-ca] Canvec.osm samples
			>>
			>> I'm getting NullPointerException in JOSM for all three files, and making
			>> sure the line feeds are unix (since I'm on linux) doesn't help. This is
			>> with
			>> JOSM 3208.
			>>
			>> Open file: /home/adam/Desktop/021L14_sample.osm (2796211 bytes)
			>> org.openstreetmap.josm.io.IllegalDataException:
			>> java.lang.NullPointerException
			>>    at org.openstreetmap.josm.io.OsmReader.parseDataSet(OsmReader.java:586)
			>>    at
			>> org.openstreetmap.josm.io.OsmImporter.importData(OsmImporter.java:42)
			>>    at
			>> org.openstreetmap.josm.io.OsmImporter.importData(OsmImporter.java:34)
			>>    at
			>>
			>> org.openstreetmap.josm.io.FileImporter.importDataHandleExceptions(FileImport
			>> er.java:57)
			>>    at
			>>
			>> org.openstreetmap.josm.actions.OpenFileAction$OpenFileTask.importData(OpenFi
			>> leAction.java:263)
			>>    at
			>>
			>> org.openstreetmap.josm.actions.OpenFileAction$OpenFileTask.realRun(OpenFileA
			>> ction.java:242)
			>>    at
			>>
			>> org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.j
			>> ava:83)
			>>    at
			>>
			>> org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:12
			>> 9)
			>>    at
			>> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
			>> ...... more stack that goes into java api libraries
			>> Caused by: java.lang.NullPointerException
			>>    at
			>> org.openstreetmap.josm.data.osm.Storage$1.getHashCode(Storage.java:317)
			>>    at org.openstreetmap.josm.data.osm.Storage.getBucket(Storage.java:246)
			>>    at org.openstreetmap.josm.data.osm.Storage.get(Storage.java:196)
			>>    at
			>> org.openstreetmap.josm.io.OsmReader$Parser.intern(OsmReader.java:126)
			>>    at
			>> org.openstreetmap.josm.io.OsmReader$Parser.startElement(OsmReader.java:273)
			>>    at
			>>
			>> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(Ab
			>> stractSAXParser.java:501)
			>> .... goes further into xerces
			>>
			>> I don't know if the stacktrace helps, or if anyone else is having problems
			>> with these files. Other .osm files open up fine on my system. I could
			>> submit
			>> this as a bug report to Josm with the sample file, but wanted to check if
			>> anyone else is having problems as well.
			>>
			>> Adam
			>>
			>>
			>> On Thu, Apr 1, 2010 at 11:05 PM, Sam Vekemans <
			>> acrosscanadatrails at gmail.com>
			>> wrote:
			>>
			>>
			>>        Thanks,
			>>        But its oodles of people who help with the process.
			>>
			>>        Speaking of which, i'll have the complete Ibycus 3.0 Garmin
			>> MapSource
			>>        IMG files available for download as single (grouped) .zip files
			>>        available soon.
			>>        It will still be at least a year before we get our map to that
			>> level.
			>>
			>>        Sam
			>>
			>>
			>>        <snip>
			>>        For those who are interesting to have a look at sample datasets,
			>> you
			>> can download them from
			>>
			>>        OSM wiki http://wiki.openstreetmap.org/wiki/CanVec#Sample_Datasets
			>> <http://wiki.openstreetmap.org/wiki/CanVec#Sample_Datasets>
			>>        NRCan ftp://ftp2.cits.rncan.gc.ca/osm/pub
			>>
			>>        Have fun (I hope!-)
			>>
			>>        Daniel
			>>
			>>
			>>        _______________________________________________
			>>        Talk-ca mailing list
			>>        Talk-ca at openstreetmap.org
			>>        http://lists.openstreetmap.org/listinfo/talk-ca
			>>
			>>
			>>
			>>
			>>
			>

			--
			Twitter: @Acrosscanada
			Blogs: http://acrosscanadatrails.posterous.com/
			http://Acrosscanadatrails.blogspot.com
			Facebook: http://www.facebook.com/sam.vekemans
			Skype: samvekemans
			OpenStreetMap IRC: http://irc.openstreetmap.org
			@Acrosscanadatrails

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/talk-ca/attachments/20100506/94ad2a57/attachment.html>