[OSM-talk] [OSM-dev] Bug Bounties

Robert (Jamie) Munro rjmunro at arjam.net
Tue Apr 24 14:31:43 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Roozbeh Pournader wrote:
> On 4/24/07, Robert (Jamie) Munro <rjmunro at arjam.net> wrote:
>> I thought the idea of that bug was to replace the whole thing with a
>> single script like this (untested as I don't have a tile server):
>> [...]
> 
> Well, the number of files involved don't really matter, but I wanted
> to change things minimally to make sure I introduce fewer bugs. So I
> made sure I don't change render_from_list much.

I mostly wrote my script last night, and was meaning to finish it up,
but you beat me to it, so I thought I may as well post what I had. If I
am judged to have won the money (or a share of it), I'd like to offer
the money for someone to work on TomTom linux - perhaps by porting an
embedded distro like http://familiar.handhelds.org/ to the TomTom
hardware platform and / or porting PostGIS and mapnik to that distro.

> Anyway, I believe your version still needs some cleanup, as the Ruby
> shows (like with File.size).

Whoops - missed one. It should be os.path.getsize(filename) (as used 2
lines further down).

> At the same time you have done some
> things much better than me (like putting the pid into the lockfile),
> but let's wait for some comment from SteveC and see what he thinks
> about the general layout.

Although I forgot to make sure the lock file is removed - it needs a try
finally around the last few lines:

try:
  for tile_data in tile_cursor:
    dotile(tile_data[0], tile_data[1], tile_data[2])

finally:
  # Remove pidfile when we finish
  os.remove(pidfile)

Robert (Jamie) Munro
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD4DBQFGLga9z+aYVHdncI0RAr65AJY9LgpapCiZ+Bj/unVQHOeC00qOAKCPWpC6
7f41NFtlyQ3O5rx/H593PQ==
=gFRW
-----END PGP SIGNATURE-----




More information about the talk mailing list