[OSM-talk] HTTPS all the Things (Automated Edit)

[Mateusz Konieczny]

Crossing country border is OK for me. Problem is when one edit object is in say Moscow and second
just across Bering Strait resulting in edit bounding box going across entire continent.

In my bots I use 0.1 degrees as max size of bounding box in both latitute and longuitude,
except cases where edited objects are larger.

https://github.com/matkoniecz/osm_bot_abstraction_layer/blob/master/osm_bot_abstraction_layer/split_into_packages.py#L9 <https://github.com/matkoniecz/osm_bot_abstraction_layer/blob/master/osm_bot_abstraction_layer/split_into_packages.py#L9>

Feb 26, 2019, 1:48 PM by bryce at jasmer.com:

> How would you feel about bounding boxes that cross country borders but are 3 geohash digits or smaller? (Sorry I cant give you an example at the moment, the power has been out so I can’t access tools on my computer.) I’m not sure what your definition of enormous is and what would be an acceptable size. 
>
> On Tue, Feb 26, 2019 at 4:39 AM Mateusz Konieczny <> matkoniecz at tutanota.com <mailto:matkoniecz at tutanota.com>> > wrote:
>
>>
>> In that case this mechanical edit makes sense for me (as long as edits 
>> will not create enormous bounding boxes due to grouping edits across country in one edit)
>>
>> Feb 26, 2019, 1:34 PM by >> bryce at jasmer.com <mailto:bryce at jasmer.com>>> :
>>
>>> Correct. No change will be made on anything other than the most straightforward of redirects. So even >>> http://example.com <http://example.com>>>>  -> >>> https://example.com/home.aspx <https://example.com/home.aspx>>>>  will be ignored. 
>>>
>>> On Tue, Feb 26, 2019 at 4:23 AM Frederik Ramm <>>> frederik at remote.org <mailto:frederik at remote.org>>>> > wrote:
>>>
>>>> Hi,
>>>>
>>>> On 26.02.19 12:47, Mateusz Konieczny wrote:
>>>> > So when >>>> http://domainname.com <http://domainname.com>>>>>  redirects to
>>>> > >>>> https://some-other-domainname.com <https://some-other-domainname.com>>>>>  <>>>> http://domainname.com <http://domainname.com>>>>> >
>>>> > no edit will be made, right?
>>>>
>>>> The logic for this appears to be here
>>>>
>>>> https://gitlab.com/b-jazz/https_all_the_things/blob/master/src/httpsosm.py#L132-137 <https://gitlab.com/b-jazz/https_all_the_things/blob/master/src/httpsosm.py#L132-137>
>>>>
>>>> which reads:
>>>>
>>>> if any((website.replace('http://', 'https://', 1) == new_location,
>>>>                        website.replace('http://', 'https://', 1) + '/'
>>>> == new_location,                             website.replace('http://',
>>>> '>>>> https://www. <https://www.>>>>> ', 1) == new_location,
>>>> website.replace('http://', '>>>> https://www. <https://www.>>>>> ', 1) + '/' == new_location,
>>>>                          website.replace('>>>> http://www. <http://www.>>>>> ', 'https://', 1)
>>>> == new_location,
>>>> website.replace('>>>> http://www. <http://www.>>>>> ', 'https://', 1) + '/' == new_location)):
>>>>                        element['tags']['website'] = new_location
>>>>
>>>> Bye
>>>> Frederik
>>>>
>>>> -- 
>>>> Frederik Ramm  ##  eMail >>>> frederik at remote.org <mailto:frederik at remote.org>>>>>   ##  N49°00'09" E008°23'33"
>>>>
>>>> _______________________________________________
>>>> talk mailing list
>>>> talk at openstreetmap.org <mailto:talk at openstreetmap.org>
>>>> https://lists.openstreetmap.org/listinfo/talk <https://lists.openstreetmap.org/listinfo/talk>
>>>>
>>
>> _______________________________________________
>>  talk mailing list
>>  >> talk at openstreetmap.org <mailto:talk at openstreetmap.org>
>>  >> https://lists.openstreetmap.org/listinfo/talk <https://lists.openstreetmap.org/listinfo/talk>
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/talk/attachments/20190226/6d1a7d0c/attachment.html>